Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added reproducible ZIP example #365

Closed
wants to merge 1 commit into from
Closed

Conversation

guss77
Copy link

@guss77 guss77 commented May 17, 2018

@coveralls
Copy link

coveralls commented May 17, 2018

Coverage Status

Coverage decreased (-3.9%) to 92.658% when pulling 5bf9a9c on guss77:patch-1 into 8887b70 on rubyzip:master.

@tilsammans
Copy link

@simonoff any chance this might get merged?

@GrimmDaddy
Copy link

zip -X -r foo1.zip foo; sleep 5; touch foo/*; zip -X -r foo2.zip foo; cmp foo1.zip foo2.zip

@hainesr
Copy link
Member

hainesr commented Jun 20, 2021

Thanks for the PR.
The default in Rubyzip is now (finally) to record the last modified time of a file as it's added to the archive, and then preserve that time when extracting. So I think this note is no longer needed. Please raise an issue if that's not the case - I am interested in making sure Rubyzip can be used for reproducibility purposes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants