Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regression caused by automatic Rubocop fixes #355

Merged
merged 1 commit into from Mar 30, 2018
Merged

Fix regression caused by automatic Rubocop fixes #355

merged 1 commit into from Mar 30, 2018

Commits on Feb 23, 2018

  1. Fix regression caused by Rubocop cleanup 

    InputStream:

```
if @current_entry && @current_entry.gp_flags & 8 == 8 && @current_entry.crc == 0 \
  && @current_entry.compressed_size == 0 \
  && @current_entry.empty? && !@internal
```

`Zip::Entry#empty?` doesn't exist, but an automatic Rubocop check thought it should be converted from `size == 0`.

Unfortunately, this is tricky to write a test for as it only fails under some very specific conditions.
    @pnomolos
    pnomolos committed Feb 23, 2018
    Copy the full SHA
    ffd0b67 View commit details
    Browse the repository at this point in the history