Allow Tempfile as IO for OutputStream::write_buffer #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This would be great to have! For now I'm using this workaround: http://thinkingeek.com/2013/11/15/create-temporary-zip-file-send-response-rails/ |
|
What the reason to use Tempfile for write buffer if you can use StringIO? |
|
Well I wouldn't want to store the whole zip file into memory; isn't that what happens if you use StringIO? |
|
As @jvdp mentioned, using a Tempfile lets us write to the buffer without forcing us to store the whole string in memory. |
|
@jacobsimeon can you fix tests for jruby and ruby 1.9.3 ? |
simonoff
added a commit
that referenced
this pull request
Feb 2, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #146