Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming the Zip module to RubyZip #145

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

davidhooey
Copy link

  • To cover Issue Rename Zip module to RubyZip #132
  • All tests pass.
  • Successfully used the renamed module to avoid conflict with the rawr module.
  • Updated README.md but may need more clarification from the owners.

@simonoff
Copy link
Member

What about compatibility level? What will be with others? It's compatibility brake and can be done only on major version changes. Like was 0.x -> 1.x. The need to create 2.x version?

@davidhooey
Copy link
Author

Very true! It will break dependent gems. I agree with a 2.0 version number. If this is something that if of interest, I can bump the version number and resubmit the PR?

On Mar 20, 2014, at 9:46 AM, Alexander Simonov notifications@github.com wrote:

What about compatibility level? What will be with others? It's compatibility brake and can be done only on major version changes. Like was 0.x -> 1.x. The need to create 2.x version?


Reply to this email directly or view it on GitHub.

@simonoff
Copy link
Member

For 2.0 I need to refactor extras first. There is no time to release new version.

@davidhooey
Copy link
Author

Sounds good. When your refactors are complete, I can help with the rename if needed.

On Mar 20, 2014, at 10:00 AM, Alexander Simonov notifications@github.com wrote:

For 2.0 I need to refactor extras first. There is no time to release new version.


Reply to this email directly or view it on GitHub.

@simonoff
Copy link
Member

Ok. I will inform you when it will be done.

@sandstrom
Copy link

I agree aligning the module name and the gem-name would be nice. But I'd rather prefer to have the gem renamed to zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants