Merge pull request #358 from idoru/handle-gpbit-3

Handle stored files with general purpose bit 3 set
rubyzip · Apr 23, 2018 · f073f64 · f073f64
2 parents 05af123 + c787d94
commit f073f64
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 3 deletions.
diff --git a/lib/zip/entry.rb b/lib/zip/entry.rb
@@ -500,7 +500,7 @@ def get_input_stream(&block)
         end
       else
         zis = ::Zip::InputStream.new(@zipfile, local_header_offset)
-        zis.instance_variable_set(:@internal, true)
+        zis.instance_variable_set(:@complete_entry, self)
         zis.get_next_entry
         if block_given?
           begin

diff --git a/lib/zip/input_stream.rb b/lib/zip/input_stream.rb
@@ -129,7 +129,7 @@ def open_entry
       end
       if @current_entry && @current_entry.gp_flags & 8 == 8 && @current_entry.crc == 0 \
         && @current_entry.compressed_size == 0 \
-        && @current_entry.size == 0 && !@internal
+        && @current_entry.size == 0 && !@complete_entry
         raise GPFBit3Error,
               'General purpose flag Bit 3 is set so not possible to get proper info from local header.' \
               'Please use ::Zip::File instead of ::Zip::InputStream'
@@ -143,7 +143,11 @@ def get_decompressor
       if @current_entry.nil?
         ::Zip::NullDecompressor
       elsif @current_entry.compression_method == ::Zip::Entry::STORED
-        ::Zip::PassThruDecompressor.new(@archive_io, @current_entry.size)
+        if @current_entry.gp_flags & 8 == 8 && @current_entry.crc == 0 && @current_entry.size == 0 && @complete_entry
+          ::Zip::PassThruDecompressor.new(@archive_io, @complete_entry.size)
+        else
+          ::Zip::PassThruDecompressor.new(@archive_io, @current_entry.size)
+        end
       elsif @current_entry.compression_method == ::Zip::Entry::DEFLATED
         header = @archive_io.read(@decrypter.header_bytesize)
         @decrypter.reset!(header)

diff --git a/test/data/gpbit3stored.zip b/test/data/gpbit3stored.zip
diff --git a/test/file_test.rb b/test/file_test.rb
@@ -55,6 +55,12 @@ def test_create_from_scratch_with_old_create_parameter
     assert_equal(2, zfRead.entries.length)
   end
 
+  def test_get_input_stream_stored_with_gpflag_bit3
+    ::Zip::File.open('test/data/gpbit3stored.zip') do |zf|
+      assert_equal("foo\n", zf.read("foo.txt"))
+    end
+  end
+
   def test_get_output_stream
     entryCount = nil
     ::Zip::File.open(TEST_ZIP.zip_name) do |zf|