Configure Naming/MemoizedInstanceVariableName in source.

Rather than turn it off for a whole file, it's better to mark these exceptions in comments.
rubyzip · Feb 29, 2020 · c30d9df · c30d9df
1 parent f9b161e
commit c30d9df
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 8 deletions.
diff --git a/.rubocop.yml b/.rubocop.yml
@@ -50,12 +50,6 @@ Metrics/MethodLength:
   Exclude:
     - 'test/**/*.rb'
 
-# Rubocop confuses these as instances of "memoization".
-Naming/MemoizedInstanceVariableName:
-  Exclude:
-    - 'lib/zip/extra_field/old_unix.rb'
-    - 'lib/zip/extra_field/unix.rb'
-
 # Set a consistent way of checking types.
 Style/ClassCheck:
   EnforcedStyle: kind_of?

diff --git a/lib/zip/extra_field/old_unix.rb b/lib/zip/extra_field/old_unix.rb
@@ -25,7 +25,7 @@ def merge(binstr)
       @uid ||= uid
       @gid ||= gid
       @atime ||= atime
-      @mtime ||= mtime
+      @mtime ||= mtime # rubocop:disable Naming/MemoizedInstanceVariableName
     end
 
     def ==(other)

diff --git a/lib/zip/extra_field/unix.rb b/lib/zip/extra_field/unix.rb
@@ -21,7 +21,7 @@ def merge(binstr)
 
       uid, gid = content.unpack('vv')
       @uid ||= uid
-      @gid ||= gid
+      @gid ||= gid # rubocop:disable Naming/MemoizedInstanceVariableName
     end
 
     def ==(other)