Fix Style/NumericLiterals cop.

rubyzip · Feb 9, 2020 · 3e34d3b · 3e34d3b
1 parent 15300f7
commit 3e34d3b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 10 deletions.
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
@@ -130,12 +130,6 @@ Style/ModuleFunction:
 Style/MutableConstant:
   Enabled: false
 
-# Offense count: 2
-# Cop supports --auto-correct.
-# Configuration parameters: Strict.
-Style/NumericLiterals:
-  MinDigits: 6
-
 # Offense count: 23
 # Cop supports --auto-correct.
 # Configuration parameters: AutoCorrect, EnforcedStyle, IgnoredMethods.

diff --git a/test/stored_support_test.rb b/test/stored_support_test.rb
@@ -10,11 +10,11 @@ def test_read
     Zip::InputStream.open(STORED_ZIP_TEST_FILE) do |zis|
       entry = zis.get_next_entry
       assert_equal 'file1.txt', entry.name
-      assert_equal 1327, entry.size
+      assert_equal 1_327, entry.size
       assert_equal ::File.open(INPUT_FILE1, 'r').read, zis.read
       entry = zis.get_next_entry
       assert_equal 'file2.txt', entry.name
-      assert_equal 41234, entry.size
+      assert_equal 41_234, entry.size
       assert_equal ::File.open(INPUT_FILE2, 'r').read, zis.read
     end
   end
@@ -23,11 +23,11 @@ def test_encrypted_read
     Zip::InputStream.open(ENCRYPTED_STORED_ZIP_TEST_FILE, 0, Zip::TraditionalDecrypter.new('password')) do |zis|
       entry = zis.get_next_entry
       assert_equal 'file1.txt', entry.name
-      assert_equal 1327, entry.size
+      assert_equal 1_327, entry.size
       assert_equal ::File.open(INPUT_FILE1, 'r').read, zis.read
       entry = zis.get_next_entry
       assert_equal 'file2.txt', entry.name
-      assert_equal 41234, entry.size
+      assert_equal 41_234, entry.size
       assert_equal ::File.open(INPUT_FILE2, 'r').read, zis.read
     end
   end