Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Fix "::set-output" deprecation #287

Merged
merged 2 commits into from Nov 28, 2023

Conversation

tisba
Copy link
Collaborator

@tisba tisba commented Jun 5, 2023

Looks like Github is postponing the removal, but IMO we should still address this, see https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/:

Our telemetry shows significant usage of these commands. Given the number of impacted customers we are postponing the removal.

SCR-20230605-iccc

@tisba tisba force-pushed the fix-ci-set-output-deprecation branch from 15176e9 to c7799ba Compare June 5, 2023 06:43
@tisba
Copy link
Collaborator Author

tisba commented Jun 5, 2023

hmm, we might want to set a reasonable timeout on our jobs maybe. Looks like the macOS truffleruby job hang for 6 hours without making progress 🤷

In any case, has (most likely) nothing to do with this changeset.

@tisba tisba requested a review from lloeki June 24, 2023 13:40
@tisba
Copy link
Collaborator Author

tisba commented Jun 24, 2023

Feel free to merge @lloeki (I can't).

@lloeki lloeki merged commit fbf3301 into rubyjs:main Nov 28, 2023
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants