Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

False positive on OOM error #212

Merged
merged 3 commits into from Jul 6, 2021
Merged

False positive on OOM error #212

merged 3 commits into from Jul 6, 2021

Commits on Jul 5, 2021

  1. gc callback can happen between init and set 

    this causes a confusing OOM crash because max mem is 0 at this point, so if the callback is hit, then the isolate will terminate no matter what.
    @seanmakesgames
    seanmakesgames committed Jul 5, 2021
    Copy the full SHA
    e1881bb View commit details
    Browse the repository at this point in the history

  2. rem printf

    @seanmakesgames
    seanmakesgames committed Jul 5, 2021
    Copy the full SHA
    46dd270 View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2021

  1. Update ext/mini_racer_extension/mini_racer_extension.cc 

    Co-authored-by: nightpool <nightpool@users.noreply.github.com>
    @seanmakesgames @nightpool
    seanmakesgames and nightpool committed Jul 6, 2021
    Copy the full SHA
    cdbdbc2 View commit details
    Browse the repository at this point in the history