Skip to content

Commit

Permalink
Merge branch 'libv8-node-18'
Browse files Browse the repository at this point in the history
  • Loading branch information
lloeki committed May 27, 2023
2 parents c0a6a34 + 0978356 commit b45a4c7
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions ext/mini_racer_extension/mini_racer_extension.cc
Original file line number Diff line number Diff line change
Expand Up @@ -518,7 +518,7 @@ nogvl_context_eval(void* arg) {
MaybeLocal<Script> parsed_script;

if (eval_params->filename) {
origin = new v8::ScriptOrigin(*eval_params->filename);
origin = new v8::ScriptOrigin(isolate, *eval_params->filename);
}

parsed_script = Script::Compile(context, *eval_params->eval, origin);
Expand Down Expand Up @@ -791,7 +791,7 @@ static bool run_extra_code(Isolate *isolate, Local<v8::Context> context,
}
Local<String> resource_name =
String::NewFromUtf8(isolate, name).ToLocalChecked();
ScriptOrigin origin(resource_name);
ScriptOrigin origin(isolate, resource_name);
ScriptCompiler::Source source(source_string, origin);
Local<Script> script;
if (!ScriptCompiler::Compile(context, &source).ToLocal(&script))
Expand Down
4 changes: 2 additions & 2 deletions lib/mini_racer/version.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# frozen_string_literal: true

module MiniRacer
VERSION = "0.7.0"
LIBV8_NODE_VERSION = "~> 17.9.1.0"
VERSION = "0.8.0"
LIBV8_NODE_VERSION = "~> 18.16.0.0"
end

0 comments on commit b45a4c7

Please sign in to comment.