Upgrade to libv8 8.4, fix slightly flakey test

rubyjs · Jul 15, 2020 · 1263283 · 1263283
1 parent 21cda0e
commit 1263283
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/mini_racer.gemspec b/mini_racer.gemspec
@@ -31,7 +31,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "minitest", "~> 5.0"
   spec.add_development_dependency "rake-compiler"
 
-  spec.add_dependency 'libv8', '> 7.3'
+  spec.add_dependency 'libv8', '> 8.4'
   spec.require_paths = ["lib", "ext"]
 
   spec.extensions = ["ext/mini_racer_extension/extconf.rb"]

diff --git a/test/mini_racer_test.rb b/test/mini_racer_test.rb
@@ -319,7 +319,7 @@ def test_max_memory_for_call
         s = val;
       }
     JS
-    context.call('set_s', 1000)
+    context.call('set_s', 2000)
     assert_raises(MiniRacer::V8OutOfMemoryError) { context.call('memory_test') }
     s = context.eval('s')
     assert_operator(s, :>, 100_000)
@@ -448,7 +448,7 @@ def test_invalid_warmup_sources_throw_an_exception
     end
   end
 
-  def test_invalid_warmup_sources_throw_an_exception
+  def test_invalid_warmup_sources_throw_an_exception_2
     assert_raises(ArgumentError) do
       MiniRacer::Snapshot.new('function f() { return 1 }').warmup!([])
     end