This repository has been archived by the owner on Dec 4, 2023. It is now read-only.
Update to 8.4.371.19 #300
Closed
Update to 8.4.371.19 #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This requires changing our checkout strategy to check out the branch-heads branch (as documented at https://v8.dev/docs/version-numbers) instead of using the 8.4.371 branch, which never gets patches (it's always locked to 8.4.371.0). We could also specify the v8 patch version manually, and i'm open to doing that, just wanted to do this to get it working.
|
Hoping this one will pass CI as #299 seems to be stuck. |
|
I used |
Using bisect, I was able to find that the build error was introduced in v8/v8@5bbca54, so let's use the version before that one while we wait for upstream to merge the patch (https://bugs.chromium.org/p/v8/issues/detail?id=10708)
Merged
|
closed in favor of #301 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the version currently used by Chrome stable. 8.5 is in beta. see https://omahaproxy.appspot.com/ for more version information
Using .19requires changing our checkout strategy to check out the branch-heads branch (as documented at https://v8.dev/docs/version-numbers) instead of using the 8.4.371 branch, which never gets patches (it's always locked to 8.4.371.0).
We could also specify the v8 patch version manually, and i'm open to doing that, just wanted to do this to get it working.