Skip to content
This repository has been archived by the owner on Dec 4, 2023. It is now read-only.

Bump version from 7.3 to 8.1 #297

Closed
wants to merge 2 commits into from

Conversation

ksylvest
Copy link

@ksylvest ksylvest commented May 9, 2020

Also freezing version constant and switching from double to single quotes to match style used in project.

Also freezing version constant and switching from double to single
quotes to match style used in project.
@runlevel5
Copy link
Contributor

LGTM 👍

@runlevel5
Copy link
Contributor

@ksylvest Would you be able to verify if this new version works fine with https://github.com/rubyjs/mini_racer?

@ksylvest
Copy link
Author

ksylvest commented May 26, 2020

@runlevel5 Thanks for the response / review. I ran into some issues during that verification:

#298

Did you want to hold off on the merge until that is fixed?

@runlevel5
Copy link
Contributor

@ksylvest I would hold off any version bump till mini_racer catches up.

The recent bump to latest 7.3 still causes issue with mini_racer

@nightpool
Copy link
Collaborator

Thanks for your contribution! After many months and many contributors, we finally managed to upgrade to V8 8.4 here: #301, with the corresponding mini_racer PR here: rubyjs/mini_racer#166

Thanks again!

@nightpool nightpool closed this Jul 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants