Use last good version before build error

Using bisect, I was able to find that the build error was introduced in v8/v8@5bbca54, so let's use the version before that one while we wait for upstream to merge the patch (https://bugs.chromium.org/p/v8/issues/detail?id=10708)
rubyjs · Jul 17, 2020 · c46dcba · c46dcba
1 parent 5c7c6e3
commit c46dcba
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,7 @@
+### v8.4.255.0 - 2020-07-15
+
+* Update upstream v8 version to 8.4.255.0
+
 ### v7.3.495.0 - 2020-04-14
 
 * Update upstream v8 version to 7.3.495.0

diff --git a/ext/libv8/builder.rb b/ext/libv8/builder.rb
@@ -65,7 +65,7 @@ def setup_python!
     # then this will be 4.5.95
     #
     def source_version
-      Libv8::V8_MINOR_VERSION
+      Libv8::VERSION.gsub(/\.[^.]+$/, '')
     end
 
     ##
@@ -84,7 +84,7 @@ def setup_build_deps!
 
         Dir.chdir('v8') do
           system 'git fetch origin'
-          unless system "git checkout branch-heads/#{source_version}"
+          unless system "git checkout #{source_version}"
             fail "unable to checkout source for v8 #{source_version}"
           end
           system "gclient sync" or fail "could not sync v8 build dependencies"

diff --git a/lib/libv8/version.rb b/lib/libv8/version.rb
@@ -1,4 +1,3 @@
 module Libv8
-  V8_MINOR_VERSION = "8.4"
-  VERSION = "8.4.371.0"
+  VERSION = "8.4.255.0"
 end
diff --git a/vendor/depot_tools b/vendor/depot_tools