Skip to content

Commit

Permalink
Fix compatibility with psych 4.0
Browse files Browse the repository at this point in the history
  • Loading branch information
@lloeki
lloeki committed Jun 20, 2021
1 parent 299a317 commit 6bbb084
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion ext/libv8-node/location.rb
View file
Expand Up @@ -18,7 +18,7 @@ def install!

def self.load!
File.open(Pathname(__FILE__).dirname.join('.location.yml')) do |f|
YAML.load(f) # rubocop:disable Security/YAMLLoad
YAML.respond_to?(:unsafe_load) ? YAML.unsafe_load(f) : YAML.load(f) # rubocop:disable Security/YAMLLoad
end
end

Expand Down

7 comments on commit 6bbb084

@h0jeZvgoxFepBQ2C
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you release a new version with this change included? Would be great!

@lloeki
Copy link
Collaborator Author

@lloeki lloeki commented on 6bbb084 Jul 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's on the table, I just did not have time to proceed with it :(

@h0jeZvgoxFepBQ2C
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, would be cool if you could release one if you have time ❤️

@lloeki
Copy link
Collaborator Author

@lloeki lloeki commented on 6bbb084 Jul 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'll be coming up together with node 16.x rubyjs/mini_racer#210

@mdesantis
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lloeki hello! What about releasing this fix before node 16.x? it seems that rubyjs/mini_racer#210 is going to require some more time

@h0jeZvgoxFepBQ2C
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, would be great if you could release it maybe before? 👍

@lloeki
Copy link
Collaborator Author

@lloeki lloeki commented on 6bbb084 Oct 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm seeing the finish line on a very important project, I think I'll be able to tackle this very soon (EOW~next week).

Please sign in to comment.