Rename credential email to identifier in WebAuthn poller #7623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
segiddins
approved these changes
May 2, 2024
deivid-rodriguez
approved these changes
May 3, 2024
There was a problem hiding this comment.
Oh my, thanks for fixing this @jenshenny! And sorry for creating such a stupid regression 馃槵
|
I'll sneak in this fix into the versions I'm about to release! |
deivid-rodriguez
added a commit
that referenced
this pull request
May 3, 2024
Rename credential email to identifier in WebAuthn poller (cherry picked from commit 53c6223)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
Fixes #7553,
#7422 renames credential email to identifier so it fits username and email. However, this wasn't updated in the Webauthn logic, breaking MFA sign ins with it.
What is your fix for the problem, implemented in this PR?
Use the identifier key instead of email when referencing credentials in the webauthn poller. Added error handling such that future renames will be caught through tests.
Thinking if there is a way to not pass credentials to the poller class and have it be dependent in the long term. 馃
Make sure the following tasks are checked