Don't fully require rubygems from rubygems/package to prevent some circular require warnings when using Bundler
#7612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
force-pushed
the
deivid-rodriguez/circular-require
branch
2 times, most recently
from
55c00f8
to
973a2bc
Compare
deivid-rodriguez
force-pushed
the
deivid-rodriguez/circular-require
branch
from
973a2bc
to
241d0aa
Compare
simi
reviewed
Apr 26, 2024
|
Just confirming that the change to |
deivid-rodriguez
pushed a commit
that referenced
this pull request
Apr 30, 2024
Fix circular require warning (cherry picked from commit 0ecd098)
deivid-rodriguez
changed the title
rubygems from rubygems/package to prevent some circular require warnings when using Bundler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
Since bbe4da0, cached gems are considered more frequently, and considering cached gems uses
Gem::Packagebecause it extracts specs from cached packages.This introduced a circular dependency because due to the feature introduced by 963cb65, a
bundle execinvocation will requirebundler/setupat the end ofrubygemsrequire, and that (due to the above change) will requirerubygems/package, which since 73c199b requires "rubygems" again, causing the circularity.What is your fix for the problem, implemented in this PR?
My fix is to not require
rubygemsfromrubygems/package. Apparently it's not necessary.Fixes #7611
Make sure the following tasks are checked