Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update --ext=rust to support compiling the native extension from source #7610

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

karreiro
Copy link

What was the end-user or developer problem that led to this PR?

I needed to apply some tiny changes to the skeleton generated by the --ext=rust option to compile my native extension from source.

What is your fix for the problem, implemented in this PR?

When gem consumers install a gem with a native extension and their platform is not included the pre-compiled bundles, they need to compile it locally and rely on the extconf.rb file.

Referencing the extconf.rb file in the gemspec is required to make that work. We also need to include rb_sys as a dependency because the Rust extconf.rb depends on it.

Here's a demo of this change in action :)

Screen.Recording.2024-04-25.at.21.22.36.mov

Copy link

welcome bot commented Apr 25, 2024

Thanks for opening a pull request and helping make RubyGems and Bundler better! Someone from the RubyGems team will take a look at your pull request shortly and leave any feedback. Please make sure that your pull request has tests for any changes or added functionality.

We use GitHub Actions to test and make sure your change works functionally and uses acceptable conventions, you can review the current progress of GitHub Actions in the PR status window below.

If you have any questions or concerns that you wish to ask, feel free to leave a comment in this PR or join our #rubygems or #bundler channel on Slack.

For more information about contributing to the RubyGems project feel free to review our CONTRIBUTING guide

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant