Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --gemfile flag to bundle pristine #7353

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

martinemde
Copy link
Member

@martinemde martinemde commented Jan 4, 2024

What was the end-user or developer problem that led to this PR?

I just switched computers and my gems needed to be rebuilt. I first tried bundle pristine --gemfile tool/bundler/vendor_gems.rb and it didn't work.

I ended up with gem pristine --all but it still seemed odd that the --gemfile flag didn't exist for pristine.

What is your fix for the problem, implemented in this PR?

Add --gemfile to bundle pristine.

Make sure the following tasks are checked

Copy link
Member

@deivid-rodriguez deivid-rodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs some test tweaks according to CI but yeah, I don't see why this command should not take a --gemfile flag!

@martinemde
Copy link
Member Author

Planning to fix the tests soon. 😵‍💫

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants