Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a global bundler cache by default #7325

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

deivid-rodriguez
Copy link
Member

What was the end-user or developer problem that led to this PR?

What is your fix for the problem, implemented in this PR?

Make sure the following tasks are checked

@MSP-Greg
Copy link
Contributor

@deivid-rodriguez

I haven't had time to look at the code, and I think this is a good idea. But, is there a way to switch back to the current behavior?

I think this will affect setup-ruby's caching when doing bundle install.

@deivid-rodriguez
Copy link
Member Author

I was not expecting this to cause issues, just maybe the cache to not be hit the first time new bundler runs on an app. But I did not really give this a lot of thought and in particular did not think of ruby/setup-ruby. I will consider it!

@MSP-Greg
Copy link
Contributor

I was working on some other things earlier. I was mistaken, as I don't think this change will affect CI for most users of setup-ruby.

Some CI may run bundle install with different Gemfile files and bundle paths, in which case they may need to download a few more gems, but they could also cache the global bundler cache independent of setup-ruby.

Sorry for the erroneous post...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants