Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print QR code for webauthn verification link #7272

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

segiddins
Copy link
Member

@segiddins segiddins commented Dec 14, 2023

What was the end-user or developer problem that led to this PR?

Accessing the webauthn verification link is difficult if you use your phone for your passkeys

What is your fix for the problem, implemented in this PR?

Use vendored rqrcode_code lib to generate a QR code for the link, which is printed out when the output is a tty

image

Make sure the following tasks are checked

@ioquatix
Copy link
Contributor

This is brilliant.

@segiddins segiddins force-pushed the segiddins/print-qr-code-for-webauthn-verification-link branch 2 times, most recently from 5bbcce7 to a5ecbd6 Compare December 14, 2023 11:44
@segiddins segiddins force-pushed the segiddins/print-qr-code-for-webauthn-verification-link branch 3 times, most recently from 421c81e to 62f3ca7 Compare January 13, 2024 06:48
@segiddins segiddins force-pushed the segiddins/print-qr-code-for-webauthn-verification-link branch from 62f3ca7 to 18e973e Compare January 13, 2024 06:52
@deivid-rodriguez
Copy link
Member

@segiddins I'm not sure I have the knowledge to review this, but I can try to get up to speed if needed. The vendoring looks fine to me, though!

One thing that immediately comes to mind though is, should the information before the QR code be updated to give a bit of context about the QR code? Maybe:

You have enabled multi-factor authentication. Please visit #{url_with_port} to authenticate via security device, or alternatively scan the QR code below. If you can't verify using WebAuthn but have OTP enabled, you can re-run the gem signin command with the --otp [your_code] option.

@segiddins
Copy link
Member Author

That's a good idea!

@simi
Copy link
Member

simi commented Feb 25, 2024

@segiddins any plan to update this PR?

@segiddins
Copy link
Member Author

Yes, I will circle back here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants