Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bundler before/after eval hooks for plugins #6961

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ccutrer
Copy link
Contributor

@ccutrer ccutrer commented Sep 14, 2023

What was the end-user or developer problem that led to this PR?

My plugin would have a much cleaner implementation if it could hook both before and after the Gemfile is evaluated (the former to easily add additional DSL methods, the latter to do verification that the new methods were properly used).

What is your fix for the problem, implemented in this PR?

Add the hooks and call them from Definition.build (not Dsl#evaluate or Dsl#eval_gemfile, so as not to interfere with the plugin-parsing pass of the Gemfile).

Make sure the following tasks are checked

@ccutrer ccutrer mentioned this pull request Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant