Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix plugin installation from gemfile #6957

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Fix plugin installation from gemfile #6957

wants to merge 6 commits into from
+470 −87

Commits on May 24, 2024

  1. Fix plugin installation from gemfile 

    Co-authored-by: Diogo Fernandes <diogofernandesop@gmail.com>
    @ccutrer @dfop02
    ccutrer and dfop02 committed May 24, 2024
    Configuration menu
    Copy the full SHA
    10d7d25 View commit details
    Browse the repository at this point in the history

  2. don't install plugins in excluded groups

    @ccutrer
    ccutrer committed May 24, 2024
    Configuration menu
    Copy the full SHA
    1ce5d2e View commit details
    Browse the repository at this point in the history

  3. Ensure plugins are installed before allowing other operations 

    Keep track of plugins during the main Gemfile pass, and then
validate that they're installed everywhere else we validate
the runtime.
    @ccutrer
    ccutrer committed May 24, 2024
    Configuration menu
    Copy the full SHA
    43ab86c View commit details
    Browse the repository at this point in the history

  4. Consider a dangling reference in the plugin index as not installed

    @ccutrer
    ccutrer committed May 24, 2024
    Configuration menu
    Copy the full SHA
    bcc8fb7 View commit details
    Browse the repository at this point in the history

  5. Fix specs, and ensure they're up to date

    @ccutrer
    ccutrer committed May 24, 2024
    Configuration menu
    Copy the full SHA
    49ce798 View commit details
    Browse the repository at this point in the history

  6. fix specs for bundler 3 

    importantly, bundler 3 automatically caches, cleans, and prunes
gems by default, so need to always keep track of plugins, even for
the regular gemfile run, and include plugins in the list of known
gems when cleaning up
    @ccutrer
    ccutrer committed May 24, 2024
    Configuration menu
    Copy the full SHA
    5acea42 View commit details
    Browse the repository at this point in the history