Make custom cop inherit RuboCop::Cop::Base
#6364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow rubocop/rubocop#7868. The legacy `RuboCop::Cop::Cop` API is soft deprecated and this PR makes custom cop inherit `RuboCop::Cop::Base` API instead. > maintain any RuboCop extensions, as the legacy API > will be removed in RuboCop 2.0. https://metaredux.com/posts/2020/10/21/rubocop-1-0.html I've confirmed that the following behavior is compatible: ```console $ bundle exec util/rubocop -r ./util/cops/deprecations --only Rubygems/Deprecations ```
simi
approved these changes
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow rubocop/rubocop#7868.
What was the end-user or developer problem that led to this PR?
The legacy
RuboCop::Cop::CopAPI is soft deprecated and will be removed in RuboCop 2.0.https://metaredux.com/posts/2020/10/21/rubocop-1-0.html
What is your fix for the problem, implemented in this PR?
This PR makes custom cop inherit
RuboCop::Cop::BaseAPI instead.I've confirmed that the following behavior is compatible:
$ bundle exec util/rubocop -r ./util/cops/deprecations --only Rubygems/DeprecationsMake sure the following tasks are checked