Avoid deprecated Gem::Platform.match in Gem::Resolver::InstallerSet #6105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
approved these changes
Dec 8, 2022
|
Thanks for merging! |
graalvmbot
pushed a commit
to oracle/truffleruby
that referenced
this pull request
Dec 21, 2022
sophie-kaleba
pushed a commit
to sophie-kaleba/truffleruby
that referenced
this pull request
Jan 16, 2023
sophie-kaleba
pushed a commit
to sophie-kaleba/truffleruby
that referenced
this pull request
Jan 17, 2023
sophie-kaleba
pushed a commit
to sophie-kaleba/truffleruby
that referenced
this pull request
Feb 16, 2023
john-heinnickel
pushed a commit
to thermofisher-jch/truffleruby
that referenced
this pull request
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
TruffleRuby emits a warning when Gem::Platform.match is used because that ignores the
What is your fix for the problem, implemented in this PR?
Use the non-deprecated method which can also use the name.
This usage was added in #5820
Probably we should really deprecate
Gem::Platform.matchso it's not used accidentally anymore.Maybe it's enough to only warn about it when running RubyGems & Bundler tests?
About deprecation, see https://github.com/rubygems/rubygems/pull/3817/files#r453293031 and #4096
cc @deivid-rodriguez
Make sure the following tasks are checked