Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain cancelled CLI deprecations clearly #5864

Merged

Conversation

tnir
Copy link
Contributor

@tnir tnir commented Aug 23, 2022

What was the end-user or developer problem that led to this PR?

Cancelled CLI deprecations in 2019 just before the release of Bundler 2.1.0 have been hard to understand and 3 years passed after.

Especially an introduction of bundle config new subcommand-based interface (rubygems/bundler#7561) was not postponed.

What is your fix for the problem, implemented in this PR?

  • Groups two CLI deprecations cancelled in Bundler 3
  • Rewrites disallowance of old subcommand interface in bundle config.
  • Uses headings 3 for CLI, Helper, and DSL sections instead of headings 4.

Updates rubygems/bundler#7561

Make sure the following tasks are checked

Resources

Signed-off-by: Takuya Noguchi takninnovationresearch@gmail.com

Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
@deivid-rodriguez deivid-rodriguez changed the title Bundler: explain cancelled CLI deprecations clearly Explain cancelled CLI deprecations clearly Aug 23, 2022
@deivid-rodriguez deivid-rodriguez merged commit 6511d77 into rubygems:master Aug 23, 2022
@tnir tnir deleted the tnir-explain-cancelled-deprecations branch August 23, 2022 08:57
deivid-rodriguez added a commit that referenced this pull request Aug 24, 2022
Bundler: explain cancelled CLI deprecations clearly
(cherry picked from commit 6511d77)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants