Fix Ruby platform incorrectly removed on bundle update
#5832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
force-pushed
the
ruby-removed
branch
from
29e5094
to
8303cbf
Compare
deivid-rodriguez
force-pushed
the
ruby-removed
branch
from
8303cbf
to
0d321c9
Compare
deivid-rodriguez
added a commit
that referenced
this pull request
Aug 24, 2022
Fix Ruby platform incorrectly removed on `bundle update` (cherry picked from commit afc7ed9)
|
It seems like this has come back with Bundler 2.4.8. 2.4.7 is fine, but going to 2.4.8 makes these unwanted changes to Gemfile.lock again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
After the fix in #5807, now some users are experimenting the removal of the "ruby" platform in situations where it's not expected.
This is because I fail to consider the case where the
Gemfileincludes gems for other platforms that have never been added to the lockfile.What is your fix for the problem, implemented in this PR?
Go through
expand_dependencies, which filters out dependencies not meant for the current platform, before checking whether the resolve for ruby is incomplete.Fixes #5830.
Make sure the following tasks are checked