Automatically unlock dependants released in lockstep #5520
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
Sometimes users might run
bundle update <transitive-dependency>
, for example, because<transitive-dependency>
has a security issue and they want to pick up a release with a fix. This will only work if there are no dependents holding the previous version. A very common case where it does not work is when dependants are released in lockstep with the gem being updated.What is your fix for the problem, implemented in this PR?
Smartly detecting dependants holding updates and retrying resolution with those unlocked is a general improvement that could be worth adding to the resolver. However, exact dependencies is a very easy case that can be detected in advance without having to retry at all.
Once dependencies to be unlocked have been figured out, have one more pass to check whether any gems have exact dependencies on them, and unlock those too.
This PR allows things like
bundle update actionview
just work, by updating the whole "Rails family" at once. It also makes it easier for dependabot to create automated PRs to fix this kind of issue.Fixes #5463.
Make sure the following tasks are checked