Fix crash when when no platform specific matches exist and show a proper error #5168
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
When a gem only has platform specific variants and none of them matches the current platform, the resolver would incorrectly allow this case, and we would get an error later down the line since that specific gem can't be materialized.
See #5088 (comment).
What is your fix for the problem, implemented in this PR?
My fix is to properly detect this case and don't consider any candidates suffering from this problem, resulting in a proper resolution error rather than a crash.
Also took the chance to improve the error message in this case.
So, now, instead of the previous output with a runtime crash and the bug report template, we get an informative message, like this
Make sure the following tasks are checked