Revert addition of support for musl variants to restore graceful fallback on Alpine
#4434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
deivid-rodriguez
changed the title
musl variantsmusl variants to restore graceful fallback on Alpine
|
@lloeki agreed with this approach, and we'll try to reintroduce this soon! For now restoring the previous behaviour. |
deivid-rodriguez
added a commit
that referenced
this pull request
Mar 8, 2021
Revert addition of support for `musl` variants to restore graceful fallback on Alpine (cherry picked from commit 4f42ac8)
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
Adding support for non-gnu libc linux platforms caused issues for gems where the gnu variant was working just fine.
What is your fix for the problem, implemented in this PR?
For now this reverts commit ce4e3f5, reversing changes made to 8a712a0.
We plan to introduce this improvement, but with a better fallback behavior where
linux-muslvariants are never installed on standard linux, andlinuxvariants are picked up as a fallback on Alpine.Closes #4425.
Reopens #3174.
Make sure the following tasks are checked