Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think it's useful to wrap network errors like this, but I might be missing something. I believe they tend to hide errors from the users. If something in particular should be better worded, I believe the builtin exception should be changed instead.
What was the end-user or developer problem that led to this PR?
I tried the new output after #4061 by disconnecting from the internet and running
bundle install
on an application. The results are:I think the message could be more informative including the underlying network error class, for example.
What is your fix for the problem, implemented in this PR?
Stop wrapping dns errors with a custom special exception to get a more wordy message. With this PR:
Make sure he following tasks are checked