Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise consistent errors with or without bundle exec #4063

Merged
merged 1 commit into from Nov 18, 2020

Conversation

deivid-rodriguez
Copy link
Member

What was the end-user or developer problem that led to this PR?

Scripts raise different exceptions depending whether they are being run with or
without bundle exec.

What is your fix for the problem, implemented in this PR?

My fix is to disable friendly errors in the bundle exec case, and let the original exception in the script being run happen.

Fixes #3368.

Make sure he following tasks are checked

@deivid-rodriguez deivid-rodriguez merged commit fbce3ba into master Nov 18, 2020
@deivid-rodriguez deivid-rodriguez deleted the friendly_errors branch November 18, 2020 15:51
deivid-rodriguez added a commit that referenced this pull request Dec 7, 2020
Raise consistent errors with or without `bundle exec`

(cherry picked from commit fbce3ba)
deivid-rodriguez added a commit that referenced this pull request Dec 7, 2020
Raise consistent errors with or without `bundle exec`

(cherry picked from commit fbce3ba)
deivid-rodriguez added a commit that referenced this pull request Dec 7, 2020
Raise consistent errors with or without `bundle exec`

(cherry picked from commit fbce3ba)
deivid-rodriguez added a commit that referenced this pull request Dec 7, 2020
Raise consistent errors with or without `bundle exec`

(cherry picked from commit fbce3ba)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding a way to disable friendly errors
2 participants