Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix edge case resulting in a crash when using zeitwerk inside a nested bundle exec invocation #4062

Merged
merged 2 commits into from Nov 18, 2020
Merged

Fix edge case resulting in a crash when using zeitwerk inside a nested bundle exec invocation #4062

merged 2 commits into from Nov 18, 2020

Commits on Nov 16, 2020

  1. Don't setup spec if we will skip it

    @deivid-rodriguez
    deivid-rodriguez committed Nov 16, 2020
    Copy the full SHA
    6b0a1aa View commit details
    Browse the repository at this point in the history

  2. Only reset settings when a gemfile is already set 

    Only thing we need to reset is settings, and only because settings are
loaded relative to the `Gemfile`, so they need to be reset if the
configured or passed `Gemfile` is not standard and will resolve to a
different root.

Resetting more stuff causes issues under some circumstances,
specifically when dependencies further tweak `Kernel.require`.
    @deivid-rodriguez
    deivid-rodriguez committed Nov 16, 2020
    Copy the full SHA
    43960ea View commit details
    Browse the repository at this point in the history