Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring back the possibility to install a plugin from path #4020

Merged
merged 1 commit into from Oct 16, 2020
Merged

Bring back the possibility to install a plugin from path #4020

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion bundler/lib/bundler/plugin/dsl.rb
View file
Open in desktop
Expand Up @@ -10,7 +10,7 @@ class PluginGemfileError < PluginError; end
# So that we don't have to override all there methods to dummy ones
# explicitly.
# They will be handled by method_missing
[:gemspec, :gem, :path, :install_if, :platforms, :env].each {|m| undef_method m }
[:gemspec, :gem, :install_if, :platforms, :env].each {|m| undef_method m }

# This lists the plugins that was added automatically and not specified by
# the user.
Expand Down
13 changes: 13 additions & 0 deletions bundler/spec/plugins/install_spec.rb
View file
Open in desktop
Expand Up @@ -208,6 +208,19 @@ def exec(command, args)
plugin_should_be_installed("ga-plugin")
end

it "accepts path sources" do
build_lib "ga-plugin" do |s|
s.write "plugins.rb"
end

install_gemfile <<-G
plugin 'ga-plugin', :path => "#{lib_path("ga-plugin-1.0")}"
G

expect(out).to include("Installed plugin ga-plugin")
plugin_should_be_installed("ga-plugin")
end

context "in deployment mode" do
it "installs plugins" do
install_gemfile <<-G
Expand Down