Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prioritize path.system over path when it makes sense #3933

Merged
merged 11 commits into from Sep 14, 2020
Merged

Prioritize path.system over path when it makes sense #3933

merged 11 commits into from Sep 14, 2020

Commits on Sep 8, 2020

  1. Reword some specs 

    To not mention deprecated `--path` flag.
    @deivid-rodriguez
    deivid-rodriguez committed Sep 8, 2020
    Copy the full SHA
    aa82f55 View commit details
    Browse the repository at this point in the history

  2. Reword spec to not mention "warnings" 

    This message is an informational piece, not a warning.
    @deivid-rodriguez
    deivid-rodriguez committed Sep 8, 2020
    Copy the full SHA
    fb22354 View commit details
    Browse the repository at this point in the history

  3. Enable path spec on all bundler versions 

    Since the behaviour is not specific to bundler 3.
    @deivid-rodriguez
    deivid-rodriguez committed Sep 8, 2020
    Copy the full SHA
    157cd18 View commit details
    Browse the repository at this point in the history

  4. Simplify Settings::Path struct

    @deivid-rodriguez
    deivid-rodriguez committed Sep 8, 2020
    Copy the full SHA
    db53fdc View commit details
    Browse the repository at this point in the history

  5. Normalize Settings.pretty_values_for 

    Always fetch the value, since we'll be using it right after.
    @deivid-rodriguez
    deivid-rodriguez committed Sep 8, 2020
    Copy the full SHA
    ba35852 View commit details
    Browse the repository at this point in the history

  6. Normalize access to DEFAULT_CONFIG 

    Keys should be defined in "ENV variable format", since that's what other
helpers expect, and makes it consistent with how the other
configurations are accessed.

This fixes the issue of the `Bundler.settings.locations` hash never
returning a `:default` key. It doesn't seem to cause any issues in
practice, but still.
    @deivid-rodriguez
    deivid-rodriguez committed Sep 8, 2020
    Copy the full SHA
    82fb614 View commit details
    Browse the repository at this point in the history

  7. Normalize access to ENV configuration 

    Makes code more consistent, and allows further refactoring.
    @deivid-rodriguez
    deivid-rodriguez committed Sep 8, 2020
    Copy the full SHA
    9ae5a3c View commit details
    Browse the repository at this point in the history

  8. Remove unnecessary to_hash 

    Since all settings are hashes now.
    @deivid-rodriguez
    deivid-rodriguez committed Sep 8, 2020
    Copy the full SHA
    a3b4a2c View commit details
    Browse the repository at this point in the history

  9. Extract a value_for helper for latter reuse

    @deivid-rodriguez
    deivid-rodriguez committed Sep 8, 2020
    Copy the full SHA
    011e418 View commit details
    Browse the repository at this point in the history

  10. Refactor prioritized access to configuration 

    By extracting a `configs` helper which holds the different configuration
levels in the right order.
    @deivid-rodriguez
    deivid-rodriguez committed Sep 8, 2020
    Copy the full SHA
    85d8ac8 View commit details
    Browse the repository at this point in the history

  11. Prioritize path.system over path when it makes sense 

    If `path.system` is configured locally, and `path` is configured
globally, gems should be installed to `path.system`.
    @deivid-rodriguez
    deivid-rodriguez committed Sep 8, 2020
    Copy the full SHA
    418998c View commit details
    Browse the repository at this point in the history