Deprecate bundle cache --all flag
#3932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's consider both use cases equally valid and don't warn any of them. Then change in the default will be signaled by changelog and documentation.
deivid-rodriguez
added a commit
that referenced
this pull request
Oct 5, 2020
Deprecate `bundle cache --all` flag (cherry picked from commit 5f97b90)
deivid-rodriguez
added a commit
that referenced
this pull request
Oct 5, 2020
Deprecate `bundle cache --all` flag (cherry picked from commit 5f97b90)
deivid-rodriguez
added a commit
that referenced
this pull request
Oct 5, 2020
Deprecate `bundle cache --all` flag (cherry picked from commit 5f97b90)
deivid-rodriguez
added a commit
that referenced
this pull request
Oct 6, 2020
Deprecate `bundle cache --all` flag (cherry picked from commit 5f97b90)
deivid-rodriguez
added a commit
that referenced
this pull request
Oct 6, 2020
Deprecate `bundle cache --all` flag (cherry picked from commit 5f97b90)
deivid-rodriguez
added a commit
that referenced
this pull request
Oct 6, 2020
Deprecate `bundle cache --all` flag (cherry picked from commit 5f97b90)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Just like we've done with the other sticky options, I think we should deprecate it in favour of explicitly configuring
bundle config set --local cache_all true.I was really unsure about what to do with the
--allflag, because looking back at the history of changes & PRs, it looked like there was a plan to deprecate it, and make it the default behavuor, so that caching git and path gems is not optional.However, I'm not really sure whether that would be correct or not, or whether it makes sense to allow not caching git & path gems.
So, I propose to keep the option as a configuration setting,
cache_all, which will be changing its default value in bundler 3 from false to true.Regarding the flag, I propose to deprecate it, since it behaves similarly to all the other sticky options which we have already deprecated.
This is a follow up to #3914.
Tasks:
I will abide by the code of conduct.