Make bundle clean --force leave default gem executables untouched
#3907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
force-pushed
the
dont_clean_default_gems
branch
2 times, most recently
from
0c6bf50
to
246508a
Compare
deivid-rodriguez
force-pushed
the
dont_clean_default_gems
branch
from
246508a
to
1ccf285
Compare
deivid-rodriguez
added a commit
that referenced
this pull request
Oct 5, 2020
Make `bundle clean --force` leave default gem executables untouched (cherry picked from commit b2a2435)
deivid-rodriguez
added a commit
that referenced
this pull request
Oct 5, 2020
Make `bundle clean --force` leave default gem executables untouched (cherry picked from commit b2a2435)
deivid-rodriguez
added a commit
that referenced
this pull request
Oct 5, 2020
Make `bundle clean --force` leave default gem executables untouched (cherry picked from commit b2a2435)
deivid-rodriguez
added a commit
that referenced
this pull request
Oct 6, 2020
Make `bundle clean --force` leave default gem executables untouched (cherry picked from commit b2a2435)
deivid-rodriguez
added a commit
that referenced
this pull request
Oct 6, 2020
Make `bundle clean --force` leave default gem executables untouched (cherry picked from commit b2a2435)
deivid-rodriguez
added a commit
that referenced
this pull request
Oct 6, 2020
Make `bundle clean --force` leave default gem executables untouched (cherry picked from commit b2a2435)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
The problem is that running
bundle clean --forceon any application will remove any executables from default gems, leaving those default gems unusable.What is your fix for the problem, implemented in this PR?
My fix is to avoid touching default gems at all when running
bundle clean --force.Writing a spec for this fix requires a bug fix in rubygems, so this PR is built on top of #3906.
Fixes #3757.
Tasks:
I will abide by the code of conduct.