Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort requirements in Gem::Requirement to succeed comparison with different order #3889

Merged
merged 8 commits into from Sep 8, 2020
Merged

Sort requirements in Gem::Requirement to succeed comparison with different order #3889

merged 8 commits into from Sep 8, 2020

Commits on Aug 18, 2020

  1. Sort requirements in Gem::Requirement to succeed comparison with diff… 

    …erent order
    @toy
    toy committed Aug 18, 2020
    Copy the full SHA
    7c14436 View commit details
    Browse the repository at this point in the history

  2. Fix tests that relied on order of requirements not been sorted

    @toy
    toy committed Aug 18, 2020
    Copy the full SHA
    0d8c337 View commit details
    Browse the repository at this point in the history

  3. Ensure sorting doesn't fail on incompatible objects

    @toy
    toy committed Aug 18, 2020
    Copy the full SHA
    9418218 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2020

  1. Sort requirements only for comparison, preserve the original order ot… 

    …herwise
    @toy
    toy committed Sep 2, 2020
    Copy the full SHA
    e241b74 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2020

  1. Memoize _sorted_requirements and _tilde_requirements which can be use… 

    …d multiple times during same comparison
    @toy
    toy committed Sep 3, 2020
    Copy the full SHA
    a1b8dac View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2020

  1. Add bundler test for gems with platform-specific dependency having di… 

    …fferent requirements order
    @toy
    toy committed Sep 4, 2020
    Copy the full SHA
    53c9377 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2020

  1. Backport the fix to bundler to work with older versions of rubygems

    @toy
    toy committed Sep 5, 2020
    Copy the full SHA
    c33914f View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2020

  1. Add comment to be able to find code to delete when support for rubyge… 

    …ms < 3.2.0 is dropped
    @toy
    toy committed Sep 6, 2020
    Copy the full SHA
    66fa8e0 View commit details
    Browse the repository at this point in the history