bring back the possibility to install a plugin from path

[nijikon]

Description:

Documentation states that it is possible to install a plugin from a path, but it's not working.

plugin 'my_plugin', path: '/path/to/plugin' # Installs from a path

What was the end-user or developer problem that led to this PR?

I was not able to install the plugin from a local path.

What is your fix for the problem, implemented in this PR?

It allows us to use the path option again.

Fixes #3355.

---

Tasks:

• Describe the problem / feature
• Write tests
• Write code to solve the problem
• Get code review from coworkers / friends

I will abide by the code of conduct.

[welcome]

Thanks for opening a pull request and helping make RubyGems and Bundler better! Someone from the RubyGems team will take a look at your pull request shortly and leave any feedback. Please make sure that your pull request has tests for any changes or added functionality.

We use GitHub Actions to test and make sure your change works functionally and uses acceptable conventions, you can review the current progress of GitHub Actions in the PR status window below.

If you have any questions or concerns that you wish to ask, feel free to leave a comment in this PR or join our #rubygems or #bundler channel on Slack.

For more information about contributing to the RubyGems project feel free to review our CONTRIBUTING guide

[deivid-rodriguez]

Hi, thanks!

Not saying that we don't want to introduce this (it makes sense to me), but I don't think this has ever been supported, so I wouldn't say "bring back". It sounds like the documentation is wrong.

Anyways, have you tried this? I was expecting it to be harder, at least requiring you to define a new plugin Path source. We'll definitely need tests here.

[deivid-rodriguez]

I just saw this is a draft PR, sorry if my feedback comes too early 😅

[nijikon]

Didn't check the backlog to see if it was ever supported, I was convinced that it was based on the documentation.

I did check if it works, I really on this heavily when I develop our diffend-ruby plugin. I would not waste your time by pushing a change that was not tested manually.

Really liked that you gave feedback on this already, the only reason why it is a draft is that I didn't write the specs yet 😅

[colby-swandale]

I'm 95% sure using path was unintentionally not working when the plugin system was shipped.

[deivid-rodriguez]

That's good to know, let's call this a bug fix then :)

[colby-swandale]

@nijikon can you just update the Changelog to say that we've fixed a bug of plugins not being installed via path and turn this into a PR.

[ngan]

This would be awesome to land. We're trying to make a bundler plugin but it's excruciatingly painful to test and debug when you can only use a local git source. The docs state that you can use path and I was excited about not having to publish a plugin I'd like to use privately.

[nijikon]

I'm going to work on this next week.

[deivid-rodriguez]

@nijikon Do you still plan to work on this?

[deivid-rodriguez]

@nijikon Went ahead and added a spec! Closing in favor of #4020.