Remove regular 2.3 testing #3020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsbt
approved these changes
Dec 6, 2019
|
@bundlerbot r=hsbt |
ghost
pushed a commit
that referenced
this pull request
Dec 6, 2019
3020: Remove regular 2.3 testing r=hsbt a=deivid-rodriguez # Description: From the failures at #3017, it seems that `actions/setup-ruby` dropped support for testing against ruby 2.3. So, I'm removing 2.3.x from our matrix. To ensure support until we actually drop it, I replaced it with an entry in the `rvm` file. # Tasks: - [x] Describe the problem / feature - [ ] Write tests - [x] Write code to solve the problem - [ ] Get code review from coworkers / friends I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md). Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
Test using rvm as a stop gap until we drop support.
deivid-rodriguez
force-pushed
the
remove_2_3_testing
branch
from
47d84cc
to
a32ee86
Compare
Canceled |
|
@bundlerbot retry |
ghost
pushed a commit
that referenced
this pull request
Dec 6, 2019
3020: Remove regular 2.3 testing r=hsbt a=deivid-rodriguez # Description: From the failures at #3017, it seems that `actions/setup-ruby` dropped support for testing against ruby 2.3. So, I'm removing 2.3.x from our matrix. To ensure support until we actually drop it, I replaced it with an entry in the `rvm` file. # Tasks: - [x] Describe the problem / feature - [ ] Write tests - [x] Write code to solve the problem - [ ] Get code review from coworkers / friends I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md). Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
Build succeeded
|
ghost
merged commit 
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
From the failures at #3017, it seems that
actions/setup-rubydropped support for testing against ruby 2.3.So, I'm removing 2.3.x from our matrix. To ensure support until we actually drop it, I replaced it with an entry in the
rvmfile.Tasks:
I will abide by the code of conduct.