Lazily load uri
#3005
Merged
Lazily load uri
#3005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `uri` library will be a default gem on ruby 2.7. Because of this, requiring `uri` at the top of this file will cause the default `uri` gem to be activated during `bundler/setup`, and that will result in gem activation conflicts. So, it's better to lazily load `uri` here.
|
Merging this quickly to be able to move rubygems/bundler#7460 forward and get full ruby 2.7 support ready as soon as possible. @bundlerbot merge |
ghost
pushed a commit
that referenced
this pull request
Dec 2, 2019
3005: Lazily load `uri` r=deivid-rodriguez a=deivid-rodriguez # Description: The `uri` library will be a default gem on ruby 2.7. Because of this, requiring `uri` at the top of this file will cause the default `uri` gem to be activated during `bundler/setup`, and that will result in gem activation conflicts. So, it's better to lazily load `uri` here. I'm using this patch in rubygems/bundler#7460 to get bundler specs passing against ruby 2.7. # Tasks: - [x] Describe the problem / feature - [ ] Write tests - [x] Write code to solve the problem - [ ] Get code review from coworkers / friends I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md). Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
Build succeeded
|
ghost
merged commit 
|
👍 |
hsbt
pushed a commit
that referenced
this pull request
Dec 13, 2019
3005: Lazily load `uri` r=deivid-rodriguez a=deivid-rodriguez # Description: The `uri` library will be a default gem on ruby 2.7. Because of this, requiring `uri` at the top of this file will cause the default `uri` gem to be activated during `bundler/setup`, and that will result in gem activation conflicts. So, it's better to lazily load `uri` here. I'm using this patch in rubygems/bundler#7460 to get bundler specs passing against ruby 2.7. # Tasks: - [x] Describe the problem / feature - [ ] Write tests - [x] Write code to solve the problem - [ ] Get code review from coworkers / friends I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md). Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The
urilibrary will be a default gem on ruby 2.7. Because of this, requiringuriat the top of this file will cause the defaulturigem to be activated duringbundler/setup, and that will result in gem activation conflicts.So, it's better to lazily load
urihere.I'm using this patch in rubygems/bundler#7460 to get bundler specs passing against ruby 2.7.
Tasks:
I will abide by the code of conduct.