Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test against Ruby 2.6 #2553

Merged
2 commits merged into from
Feb 13, 2019
Merged

Test against Ruby 2.6 #2553

2 commits merged into from
Feb 13, 2019

Conversation

segiddins
Copy link
Member

Description:

Since 2.6 has been released, we should make sure we support it!

Tasks:

  • Describe the problem / feature
  • Write tests
  • Write code to solve the problem
  • Get code review from coworkers / friends

I will abide by the code of conduct.

@@ -12,6 +12,7 @@ environment:
- ruby_version: 23-x64
- ruby_version: 24-x64
- ruby_version: 25-x64
- ruby_version: 26-x64
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ruby didn't seem to get installed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@segiddins

With normal CI, all Ruby builds (except trunk) used on Appveyor are pre-installed.

  1. The RubyInstaller2 2.6.0 build is not passing due to a last minute update to BigDecimal, which changed spec tests (added to ruby/ruby, not yet added to ruby/spec).

  2. Once released, Appveyor may take a few days (or weeks) to add the build to their images.

  3. Trunk/head is not affected.

  4. I'll ping when it's been added...

.travis.yml Outdated
@@ -12,14 +12,15 @@ rvm:
- 2.3.8
- 2.4.5
- 2.5.3
- 2.6.0
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bundler is still failing on 2.6, working on that over in rubygems/bundler#6856

@colby-swandale
Copy link
Member

@segiddins what are you thoughts are leaving 2.6 out of appveyor for the time being so that we can merge this PR?

@MSP-Greg
Copy link
Contributor

MSP-Greg commented Feb 6, 2019

See 810671e

Appveyor has not yet updated their images with Ruby 2.6.x. They will be updating with 2.6.1, along with installing both Bundler 1.7.x & 2.x.

@MSP-Greg
Copy link
Contributor

@segiddins

Appveyor has added Ruby 2.6.1.

JFYI, Bundler versions 1.17.3 & 2.0.1 are install on Ruby versions 2.3 & later. At present, trunk/head only has what's included in the Rubygems std-lib.

See:
https://ci.appveyor.com/project/MSP-Greg/appveyor-ruby/builds/22294299#L908

@hsbt
Copy link
Member

hsbt commented Feb 13, 2019

@bundlerbot r+

ghost pushed a commit that referenced this pull request Feb 13, 2019
2553: Test against Ruby 2.6 r=hsbt a=segiddins

# Description:

Since 2.6 has been released, we should make sure we support it!

# Tasks:

- [ ] Describe the problem / feature
- [ ] Write tests
- [ ] Write code to solve the problem
- [ ] Get code review from coworkers / friends

I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md).

Co-authored-by: Samuel Giddins <segiddins@segiddins.me>
Co-authored-by: SHIBATA Hiroshi <hsbt@ruby-lang.org>
@ghost
Copy link

ghost commented Feb 13, 2019

Build succeeded

@ghost ghost merged commit 9bb1f99 into master Feb 13, 2019
@ghost ghost deleted the segiddins/ruby-2.6.0 branch February 13, 2019 08:47
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants