Behaviour changes with default gems installer #2166

hsbt · 2018-02-01T05:53:35Z

Description:

A current installer of default gems only installs executable file and gemspec. It didn't resolve the real world problem.

Default gems provide to upgrade standard libraries like gem update openssl. But current installer used by gem install openssl --default is inconsistency behavior with gem update.

I change its behavior to install gem files and build native extensions. It can upgrade instructions for the old version of Ruby like 2.3 or 2.4.

Tasks:

Describe the problem / feature
Write tests
Write code to solve the problem
Get code review from coworkers / friends

I will abide by the code of conduct.

hsbt · 2018-02-02T09:56:04Z

Related with #677

segiddins · 2018-02-03T22:59:33Z

lib/rubygems/specification.rb

@@ -112,6 +112,31 @@ class Gem::Specification < Gem::BasicSpecification

  VALID_NAME_PATTERN = /\A[a-zA-Z0-9\.\-\_]+\z/ # :nodoc:

+  DEFAULT_GEMS_LIST = %w[


shouldn't this pull from Gem::Specification.select(&:default_gem?).map(&:name) ?

It's not working. default gems were determined without ruby version.

default gems were determined without ruby version

I'm not sure I understand what you mean by this?

Default gems do not depend on Ruby version.

Ex. We can install default gems from listed by https://stdgems.org/ with old ruby. But is not activated in the current specification. I hope to activate them with old ruby.

ah, good point

segiddins · 2018-02-03T23:00:09Z

It didn't resolve the real world problem.

Which real-world problem? Does this only manifest on gem update, or also gem install? Can you add a test case for the changed behavior?

bundlerbot · 2018-02-05T04:40:49Z

☔ The latest upstream changes (presumably #2177) made this pull request unmergeable. Please resolve the merge conflicts.

colby-swandale · 2018-03-01T11:25:49Z

ping @hsbt

hsbt · 2018-03-01T12:15:32Z

Which real-world problem?

If you want to use the latest version of csv with Ruby 2.4.0 via gem install csv, but RubyGems will activate csv on standard libraries. It needs to be promoted default gems on Ruby 2.4.

segiddins · 2018-03-02T07:39:57Z

lib/rubygems/installer.rb

+  def verify_default_gems
+    return unless options[:install_as_default]
+    return if Gem::Specification::DEFAULT_GEMS_LIST.include?(spec.name)
+    raise Gem::InstallError, "#{spec} is not a default gems"


not a default gem ?

segiddins · 2018-03-11T03:48:54Z

lib/rubygems/specification.rb

+    strscan
+    webrick
+    zlib
+  ] #:nodoc:


do we want to freeze this list, or otherwise append to it when we see more gems in the default directory?

Good point. I will reconsider to handle its list.

deivid-rodriguez · 2018-09-19T20:35:33Z

@hsbt I'm running into the following issue with bundler

$ gem list json

*** LOCAL GEMS ***

json (default: 2.1.0)
jsonapi-renderer (0.2.0)
multi_json (1.13.1)

$ echo -e "source 'https://rubygems.org'\ngem 'json'" > Gemfile

$ bundle
Bundle complete! 1 Gemfile dependency, 2 gems now installed.
Bundled gems are installed into `./.bundle`

$ bundle pristine
Failed to pristine json (2.1.0). Cached gem /home/deivid/.rbenv/versions/2.5.1/lib/ruby/gems/2.5.0/cache/json-2.1.0.gem does not exist.

$ gem install json
Fetching: json-2.1.0.gem (100%)
Building native extensions. This could take a while...
Successfully installed json-2.1.0
1 gem installed

$ bundle pristine
Installing json 2.1.0 with native extensions

$ gem uninstall json
Successfully uninstalled json-2.1.0

$ gem list json

*** LOCAL GEMS ***

json (default: 2.1.0)
jsonapi-renderer (0.2.0)
multi_json (1.13.1)

$ bundle pristine
Failed to pristine json (2.1.0). Cached gem /home/deivid/.rbenv/versions/2.5.1/lib/ruby/gems/2.5.0/cache/json-2.1.0.gem does not exist.

Do you think the root problem might be what this PR is trying to address?

hsbt · 2018-09-26T09:18:15Z

@deivid-rodriguez Yes, The current default-gems was inconsistency behavior.

deivid-rodriguez · 2018-09-26T10:59:37Z

Great! For starters I'm going to try and confirm whether this PR fixes the problem!

deivid-rodriguez · 2018-10-04T11:41:02Z

I tried it with this PR and I still get the same behavior. Can you confirm the issue? Maybe I didn't try it correctly.

hsbt · 2018-10-04T11:44:38Z

@deivid-rodriguez Sorry, I didn't understand that your expected behavior. Did you hope to finish gem pristine json?

deivid-rodriguez · 2018-10-04T11:48:04Z

Yeah, I hope bundle pristine would not crash.

But I just tried gem pristine json and it behaves better

$ gem pristine json
Restoring gems to pristine condition...
Skipped json-2.1.0, it is a default gem

So, this seems like a bug in bundler, not in rubygems! Sorry for the false alarm.

hsbt · 2018-10-04T11:54:48Z

@deivid-rodriguez Ah, I see. I missed bundle pristine on your first comment. It seems the issue of bundler.

deivid-rodriguez · 2019-05-01T11:06:44Z

@hsbt I'd like to move forward the work in this PR if that's ok with you?

7216: Revert "Migrate requires from exe/ to also be relative" r=hsbt a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was that in #7193, I included [a commit](d9d2bf6) to migrate requires included in bundler's executable to use `require_relative`. That broke stuff. ### What was your diagnosis of the problem? My diagnosis was the assumption that if `<install_folder>/exe/bundle` lives on a folder, the corresponding bundler lib lives on `<install_folder>/lib` doesn't hold for default gems. Default gems for gems with executables live in `site_lib` but install their executables in the standard gem location. That means that the reference commit breaks bundler when it is installed as a default gem. ### What is your fix for the problem, implemented in this PR? My fix is to revert the commit. ### Why did you choose this fix out of the possible options? I chose this fix because it's the easiest way. The proper long term fix is probably to make default gems behave in a more standard way. There's some ongoing work on that here: rubygems/rubygems#2166. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>

7216: Revert "Migrate requires from exe/ to also be relative" r=hsbt a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was that in rubygems/bundler#7193, I included [a commit](rubygems/bundler@d9d2bf6) to migrate requires included in bundler's executable to use `require_relative`. That broke stuff. ### What was your diagnosis of the problem? My diagnosis was the assumption that if `<install_folder>/exe/bundle` lives on a folder, the corresponding bundler lib lives on `<install_folder>/lib` doesn't hold for default gems. Default gems for gems with executables live in `site_lib` but install their executables in the standard gem location. That means that the reference commit breaks bundler when it is installed as a default gem. ### What is your fix for the problem, implemented in this PR? My fix is to revert the commit. ### Why did you choose this fix out of the possible options? I chose this fix because it's the easiest way. The proper long term fix is probably to make default gems behave in a more standard way. There's some ongoing work on that here: #2166. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>

hsbt · 2023-03-10T06:11:34Z

I reboot this proposal for altanative approach of https://bugs.ruby-lang.org/issues/19351

hsbt · 2024-04-18T07:45:57Z

I changed my proposal. see #7588

bronzdoc added the status: triage label Feb 1, 2018

segiddins reviewed Feb 3, 2018

View reviewed changes

segiddins reviewed Mar 2, 2018

View reviewed changes

hsbt added a commit that referenced this pull request Mar 3, 2018

Followed up #2166 (comment)

3773e15

segiddins reviewed Mar 11, 2018

View reviewed changes

hsbt added rubygems: breaking change and removed status: triage labels May 16, 2018

hsbt self-assigned this Jun 19, 2018

segiddins approved these changes Oct 3, 2018

View reviewed changes

hsbt added this to the 4.0 milestone Oct 10, 2018

hsbt mentioned this pull request Apr 18, 2019

improve gem install --default #677

Closed

deivid-rodriguez mentioned this pull request Jun 20, 2019

Revert "Migrate requires from exe/ to also be relative" rubygems/bundler#7216

Merged

deivid-rodriguez mentioned this pull request Aug 1, 2019

Default bundler version for ruby 2.6.x installations #2842

Closed

fallingicarus approved these changes Nov 23, 2021

View reviewed changes

hsbt mentioned this pull request Dec 2, 2021

Option --default does not set gems as default #5124

Open

2 tasks

rubygems deleted a comment Dec 27, 2022

hsbt added a commit that referenced this pull request Mar 10, 2023

Followed up #2166 (comment)

b61a7ce

hsbt force-pushed the install-default-gems branch from 3773e15 to b61a7ce Compare March 10, 2023 05:10

hsbt added a commit that referenced this pull request Mar 10, 2023

Followed up #2166 (comment)

289819f

hsbt force-pushed the install-default-gems branch from b61a7ce to 165b475 Compare March 10, 2023 05:22

hsbt force-pushed the install-default-gems branch 3 times, most recently from f566bd8 to a8347d7 Compare March 10, 2023 10:29

This comment was marked as spam.

Sign in to view

hsbt added 9 commits December 6, 2023 13:28

verify name of default gems

1c42747

To install files and build extensions when installing default gems.

71a579f

Followed up #2166 (comment)

7f84635

Added some of whitelisted gems for testing

0915942

Added bundler as default gems

d5ab397

Freeze constant assignment

5fb5239

Added whitelist for bundler examples

fe4d892

Guard for bundler realworld spec

2795d63

added json to whitelist

40c925f

hsbt force-pushed the install-default-gems branch from a8347d7 to 40c925f Compare December 6, 2023 04:38

./bin/rubocop -a

0e8f05d

hsbt closed this Apr 18, 2024

hsbt deleted the install-default-gems branch April 18, 2024 07:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Behaviour changes with default gems installer #2166

Behaviour changes with default gems installer #2166

hsbt commented Feb 1, 2018 •

edited

hsbt commented Feb 2, 2018

segiddins Feb 3, 2018

hsbt Mar 1, 2018

segiddins Mar 2, 2018

hsbt Mar 7, 2018

segiddins Mar 8, 2018

segiddins commented Feb 3, 2018

bundlerbot commented Feb 5, 2018

colby-swandale commented Mar 1, 2018

hsbt commented Mar 1, 2018

segiddins Mar 2, 2018

segiddins Mar 11, 2018

hsbt Mar 12, 2018

deivid-rodriguez commented Sep 19, 2018 •

edited

hsbt commented Sep 26, 2018

deivid-rodriguez commented Sep 26, 2018

deivid-rodriguez commented Oct 4, 2018

hsbt commented Oct 4, 2018

deivid-rodriguez commented Oct 4, 2018

hsbt commented Oct 4, 2018

deivid-rodriguez commented May 1, 2019

hsbt commented Mar 10, 2023

This comment was marked as spam.

hsbt commented Apr 18, 2024

		@@ -112,6 +112,31 @@ class Gem::Specification < Gem::BasicSpecification

		VALID_NAME_PATTERN = /\A[a-zA-Z0-9\.\-\_]+\z/ # :nodoc:

		DEFAULT_GEMS_LIST = %w[

Behaviour changes with default gems installer #2166

Behaviour changes with default gems installer #2166

Conversation

hsbt commented Feb 1, 2018 • edited

Description:

Tasks:

hsbt commented Feb 2, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

segiddins commented Feb 3, 2018

bundlerbot commented Feb 5, 2018

colby-swandale commented Mar 1, 2018

hsbt commented Mar 1, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

deivid-rodriguez commented Sep 19, 2018 • edited

hsbt commented Sep 26, 2018

deivid-rodriguez commented Sep 26, 2018

deivid-rodriguez commented Oct 4, 2018

hsbt commented Oct 4, 2018

deivid-rodriguez commented Oct 4, 2018

hsbt commented Oct 4, 2018

deivid-rodriguez commented May 1, 2019

hsbt commented Mar 10, 2023

This comment was marked as spam.

hsbt commented Apr 18, 2024

hsbt commented Feb 1, 2018 •

edited

deivid-rodriguez commented Sep 19, 2018 •

edited