Don't fully require rubygems
from rubygems/package
to prevent some circular require warnings when using Bundler
#7612
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
Since bbe4da0, cached gems are considered more frequently, and considering cached gems uses
Gem::Package
because it extracts specs from cached packages.This introduced a circular dependency because due to the feature introduced by 963cb65, a
bundle exec
invocation will requirebundler/setup
at the end ofrubygems
require, and that (due to the above change) will requirerubygems/package
, which since 73c199b requires "rubygems" again, causing the circularity.What is your fix for the problem, implemented in this PR?
My fix is to not require
rubygems
fromrubygems/package
. Apparently it's not necessary.Fixes #7611
Make sure the following tasks are checked