Skip to content

Commit

Permalink
Merge #2823
Browse files Browse the repository at this point in the history
2823: Remove TODO comment about warning on setting instead of pushing r=bronzdoc a=bronzdoc

# Description:
Remove TODO comment about warning on setting instead of pushing.

This methods are heavily used across specs and i personally think those warning at this point will not add much value, thoughts?
______________

I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md).


Co-authored-by: bronzdoc <lsagastume1990@gmail.com>
  • Loading branch information
bundlerbot and bronzdoc committed Dec 7, 2019
2 parents 3fcc494 + 1b7c4ca commit c1feef9
Showing 1 changed file with 5 additions and 15 deletions.
20 changes: 5 additions & 15 deletions lib/rubygems/specification.rb
Original file line number Diff line number Diff line change
Expand Up @@ -1848,29 +1848,23 @@ def executable=(o)
end

##
# Sets executables to +value+, ensuring it is an array. Don't
# use this, push onto the array instead.
# Sets executables to +value+, ensuring it is an array.

def executables=(value)
# TODO: warn about setting instead of pushing
@executables = Array(value)
end

##
# Sets extensions to +extensions+, ensuring it is an array. Don't
# use this, push onto the array instead.
# Sets extensions to +extensions+, ensuring it is an array.

def extensions=(extensions)
# TODO: warn about setting instead of pushing
@extensions = Array extensions
end

##
# Sets extra_rdoc_files to +files+, ensuring it is an array. Don't
# use this, push onto the array instead.
# Sets extra_rdoc_files to +files+, ensuring it is an array.

def extra_rdoc_files=(files)
# TODO: warn about setting instead of pushing
@extra_rdoc_files = Array files
end

Expand Down Expand Up @@ -2246,11 +2240,9 @@ def raise_if_conflicts # :nodoc:
end

##
# Sets rdoc_options to +value+, ensuring it is an array. Don't
# use this, push onto the array instead.
# Sets rdoc_options to +value+, ensuring it is an array.

def rdoc_options=(options)
# TODO: warn about setting instead of pushing
@rdoc_options = Array options
end

Expand All @@ -2269,11 +2261,9 @@ def require_path=(path)
end

##
# Set requirements to +req+, ensuring it is an array. Don't
# use this, push onto the array instead.
# Set requirements to +req+, ensuring it is an array.

def requirements=(req)
# TODO: warn about setting instead of pushing
@requirements = Array req
end

Expand Down

0 comments on commit c1feef9

Please sign in to comment.