Probably better fix to previous issue

With specific platforms by default, it sounds like we can fix a previous "duplicated spec groups" issue by calling uniq on the array of definition platforms.
rubygems · Nov 12, 2020 · 91cfcfe · 91cfcfe
1 parent 0bcf749
commit 91cfcfe
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/bundler/lib/bundler/definition.rb b/bundler/lib/bundler/definition.rb
@@ -559,7 +559,7 @@ def add_current_platform
     end
 
     def current_platforms
-      [local_platform, generic_local_platform]
+      [local_platform, generic_local_platform].uniq
     end
 
     def change_reason

diff --git a/bundler/lib/bundler/resolver.rb b/bundler/lib/bundler/resolver.rb
@@ -158,9 +158,8 @@ def search_for(dependency)
         # spec group.
         sg_ruby = sg.copy_for(Gem::Platform::RUBY)
         selected_sgs << sg_ruby if sg_ruby
-        all_platforms = @platforms + [platform]
-        next if all_platforms.to_a == [Gem::Platform::RUBY]
         sg_all_platforms = nil
+        all_platforms = @platforms + [platform]
         self.class.sort_platforms(all_platforms).reverse_each do |other_platform|
           if sg_all_platforms.nil?
             sg_all_platforms = sg.copy_for(other_platform)