Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show downloads and license information for yanked versions too #1946

Merged
merged 2 commits into from Apr 5, 2019

Conversation

dwradcliffe
Copy link
Member

@dwradcliffe dwradcliffe commented Apr 4, 2019

I'm not sure why these details were hidden. I can't think of a good reason to hide the download stats and license information for yanked versions.

This will show the downloads and license on the version page, and allow the downloads to be fetched via the API.

(Ref: twbs/bootstrap-sass#1195 (comment))

@evanphx
Copy link
Member

evanphx commented Apr 4, 2019

Approved

@dwradcliffe dwradcliffe merged commit 8437253 into master Apr 5, 2019
@dwradcliffe dwradcliffe deleted the yanked_version_details branch April 5, 2019 00:01
@rubygems-deployer rubygems-deployer temporarily deployed to staging April 5, 2019 00:09 Inactive
@dwradcliffe dwradcliffe temporarily deployed to production April 5, 2019 01:16 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants