New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add April Monthly Update #79
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments with my suggestions! We sometimes log work to slack that, although could be worth a generic mention since it's needed work that do benefit the community, it's in general not interesting for the monhtly update subscribers. This includes issues liking fixing CI, upgrading development dependencies, or fixing issues with our development environments.
I hope this makes sense!
Welcome to the RubyGems monthly update! As part of our efforts at [Ruby Together](http://rubytogether.org/), we publish a recap of the work that we’ve done the previous month. Read on to find out what updates were made to [RubyGems](https://github.com/rubygems/rubygems) and [RubyGems.org](https://github.com/rubygems/rubygems.org) in April. | ||
|
||
## RubyGems News | ||
This Month in RubyGems, we released a new version for **RubyGems(3.2.16)** and **Bundler(2.2.16)**. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also released Rubygems 3.2.17 and Bundler 2.2.17, the 5th of May. Releases didn't fall inside April, but most of the work for them was done during April, so I guess it's worth mentioning them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes for sure, they are indeed worth mentioning
- improved `bundle pristine` error if `BUNDLE_GEMFILE` does not exist - [#4536](https://github.com/rubygems/rubygems/pull/4536). | ||
- fixed CI pipeline that was broken by third party releases of development dependencies. | ||
- fixed ``"Permission denied"`` error when running Bundler specs that resulted in finding `ruby-install + chruby` to be the fix to the error - [#3957](https://github.com/rubygems/rubygems/issues/3957). | ||
- fixed `bundle cache` with an up-to-date lockfile and specs not already installed - [#4554](https://github.com/rubygems/rubygems/pull/4554) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my opinion, the updates mentioned here should only be things relevant to our users, so they should appear in the respective changelogs (https://github.com/rubygems/rubygems/blob/bb93b974100e9ddff7043e648d762e8a412be04e/bundler/CHANGELOG.md#2217-may-5-2021, https://github.com/rubygems/rubygems/blob/bb93b974100e9ddff7043e648d762e8a412be04e/CHANGELOG.md#3217--2021-05-05). In particular, the entry about "fixed CI pipeline" and the entry about "fixed Permission denied
" error shouldn't be included since they are just quality of life improvements for bundler developers, but not interesting for users.
Instead, I would mention the following as "highlights" for this month:
- We fixed an issue affecting custom
sidekiq-pro
gem servers, which was preventing users from upgrading theirsidekiq-pro
version.- We made
bundler
more secure by preventing any credentials from being logged to the screen, thus potentially preventing users from unintentionally leaking them when pasting them to a Github issue or similar situations.- We fixed a few resolution & materialization issues in bundler, and also improved rubygems handling of repositories including symlinks.
And I would include links to all releases made for more details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, thanks @deivid-rodriguez. I thought it's worth checking with you about the updates I added. Totally make sense to only add relevant updates I will take them out and add these ones.
Awaiting the relevant links so I can reference them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! For sidekiq-pro
issue, it's this link: rubygems/rubygems#4563.
For issues of redacting credentials, these: rubygems/rubygems#4564, rubygems/rubygems#4566.
For resolution and materialization issues, these: rubygems/rubygems#4556, rubygems/rubygems#4562. and for the symlinks rubygems issue, this one: rubygems/rubygems#2836.
You can also mention the changelogs for all versions for more details:
- Rubygems 3.2.16: https://github.com/rubygems/rubygems/blob/bb93b974100e9ddff7043e648d762e8a412be04e/CHANGELOG.md#3216--2021-04-08
- Bundler 2.2.16: https://github.com/rubygems/rubygems/blob/bb93b974100e9ddff7043e648d762e8a412be04e/bundler/CHANGELOG.md#2216-april-8-2021
- Rubygems 3.2.17: https://github.com/rubygems/rubygems/blob/bb93b974100e9ddff7043e648d762e8a412be04e/CHANGELOG.md#3217--2021-05-05
- Bundler 2.2.17: https://github.com/rubygems/rubygems/blob/bb93b974100e9ddff7043e648d762e8a412be04e/bundler/CHANGELOG.md#2217-may-5-2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
|
||
RubyGems saw several bug fixes and updates this month, some of which include the following: | ||
In addition to that, we made the following improvement and fixes: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say "As part of those releases" or something similar, instead of "In addition to that". The latter might confuse users into thinking the specific improvements we list have not yet been released.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, sure I can make that change too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Draft for RubyGems monthly update.
Hi @sonalkr132 and @deivid-rodriguez can you help review my draft for this month, I captured some of these updates from the commits and PRs made for the month but let me know if they are relevant or want me to add anything else.
Thanks!