Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plugin overview to reflect new plugin system #267

Merged

Conversation

rreinhardt9
Copy link
Contributor

@rreinhardt9 rreinhardt9 commented Oct 3, 2020

Resolves #268

This updates the overview of how RubyGems plugins work to reflect the new plugin system.

The plug in system was reworked to make it faster by caching plugins from gems into a central location instead of having to find and load them from each time.

In a discussion on an plugin related issue, it was discovered that the current overview in the documentation does not reflect how things work after the updates to the plugin system.

This updates the language used in the overview to match a similar change of language in that PR here: https://github.com/rubygems/rubygems/blob/a28724fdd9262d716e6facb1950387a0a6ac4c73/lib/rubygems.rb#L45-L48

plugins.md Show resolved Hide resolved
@rreinhardt9 rreinhardt9 marked this pull request as ready for review October 3, 2020 15:10
Copy link
Member

@deivid-rodriguez deivid-rodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for doing this @rreinhardt9! 😍

@deivid-rodriguez deivid-rodriguez merged commit 40054ae into rubygems:gh-pages Oct 12, 2020
@rreinhardt9 rreinhardt9 deleted the update-plugin-overview branch April 17, 2021 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update overview of how plugins work to reflect improvement in plugin system
2 participants