Fix Bundler v2 and Puma 5.x issues #289
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixing integration tests (
spec/integration_spec.rb
to work with Ruby 2.6.6)Tasks:
"http://localhost:9042/upstream/http%253A%252F%252F127.0.0.1%253A9043/"
, which are defined in upstream spec.I will abide by the code of conduct.
I am still checking to see why the upstream URL exception gets triggered. Somehow there was a change in bundler versions that causes double-url encoding.
With Ruby 2.6.6 (and Bundler v2.2.13):
With Ruby 2.5.6 (and Bundler 1.17.2):
Seems to be related to this PR?