Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bundler v2 and Puma 5.x issues #289

Closed
wants to merge 2 commits into from

Conversation

rogerhu
Copy link
Contributor

@rogerhu rogerhu commented Mar 8, 2021

Description:

Fixing integration tests (spec/integration_spec.rb to work with Ruby 2.6.6)


Tasks:

  • Bump rspec dependencies to avoid dependency conflicts.
  • Upstream URLs are now unescaped (test modified). Somehow this line gets triggered for upstream URLs such as "http://localhost:9042/upstream/http%253A%252F%252F127.0.0.1%253A9043/", which are defined in upstream spec.

I will abide by the code of conduct.

I am still checking to see why the upstream URL exception gets triggered. Somehow there was a change in bundler versions that causes double-url encoding.

With Ruby 2.6.6 (and Bundler v2.2.13):

cd spec/data/bundles/integration_spec/upstream_gems
bundle
Fetching source index from http://localhost:9042/upstream/http%3A%2F%2F127.0.0.1%3A9043/

Retrying fetcher due to error (2/4): Bundler::HTTPError Could not fetch specs from http://localhost:9042/upstream/http%3A%2F%2F127.0.0.1%3A9043/ due to underlying error <Errno::ECONNREFUSED: Failed to open TCP connection to localhost:9042 (Connection refused - connect(2) for "localhost" port 9042) (http://localhost:9042/upstream/http%3A%2F%2F127.0.0.1%3A9043/specs.4.8.gz)>

Retrying fetcher due to error (3/4): Bundler::HTTPError Could not fetch specs from http://localhost:9042/upstream/http%3A%2F%2F127.0.0.1%3A9043/ due to underlying error <Errno::ECONNREFUSED: Failed to open TCP connection to localhost:9042 (Connection refused - connect(2) for "localhost" port 9042) (http://localhost:9042/upstream/http%3A%2F%2F127.0.0.1%3A9043/specs.4.8.gz)>

Retrying fetcher due to error (4/4): Bundler::HTTPError Could not fetch specs from http://localhost:9042/upstream/http%3A%2F%2F127.0.0.1%3A9043/ due to underlying error <Errno::ECONNREFUSED: Failed to open TCP connection to localhost:9042 (Connection refused - connect(2) for "localhost" port 9042) (http://localhost:9042/upstream/http%3A%2F%2F127.0.0.1%3A9043/specs.4.8.gz)>

Could not fetch specs from http://localhost:9042/upstream/http%3A%2F%2F127.0.0.1%3A9043/ due to underlying error <Errno::ECONNREFUSED: Failed to open TCP connection to localhost:9042 (Connection refused -
connect(2) for "localhost" port 9042) (http://localhost:9042/upstream/http%3A%2F%2F127.0.0.1%3A9043/specs.4.8.gz)>

With Ruby 2.5.6 (and Bundler 1.17.2):

rvm use ruby-2.5.6
cd spec/data/bundles/integration_spec/upstream_gems
bundle
Fetching source index from http://localhost:9042/upstream/http%3A%2F%2F127.0.0.1%3A9043/

Retrying fetcher due to error (2/4): Bundler::HTTPError Could not fetch specs from http://localhost:9042/upstream/http%3A%2F%2F127.0.0.1%3A9043/
Retrying fetcher due to error (3/4): Bundler::HTTPError Could not fetch specs from http://localhost:9042/upstream/http%3A%2F%2F127.0.0.1%3A9043/
Retrying fetcher due to error (4/4): Bundler::HTTPError Could not fetch specs from http://localhost:9042/upstream/http%3A%2F%2F127.0.0.1%3A9043/
Could not fetch specs from http://localhost:9042/upstream/http%3A%2F%2F127.0.0.1%3A9043/

Seems to be related to this PR?

@rogerhu rogerhu changed the title Fix Ruby 2.6 and Puma 5.x issues Fix Ruby 2.6.6 and Puma 5.x issues Mar 8, 2021
@rogerhu rogerhu changed the title Fix Ruby 2.6.6 and Puma 5.x issues Fix Bundler v2 and Puma 5.x issues Mar 8, 2021
@bronzdoc
Copy link
Member

bronzdoc commented Jul 1, 2021

@rogerhu could you rebase master and update the PR please? thank you! 🙇

@olleolleolle
Copy link
Member

@bronzdoc Perhaps this can be closed now, we are green in CI.

@bronzdoc bronzdoc closed this Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants